It's probably easier for me since I'm not Canadian and don't have a lot emotionally vested in the classic lyrics, but the tweak here of changing "in all thy sons" to "in all of us" seems pretty tidy and appropriate for noting that women can have their patriotism commanded, too.
Changing songs for modern sensibilities or other reasons is hard, though. Never mind resistance over the reasons for those changes, tradition and the words that roll off the lips are powerfully attractive. We sing a song not just for what it says, but for the feelings that have been associated with it in past singing.
I've seen this happen with fierce debates over church hymns. There was a lot of tweaking of words in hymns in the 60s, 70, and 80s to be more inclusive, some aesthetically successful, some less so. Getting rid of references to "man" and "brothers" and the like (and, more controversially, scrubbing gender references to God) and still making lyrics scan and rhyme properly is more difficult than you may think, even just mechanically.
In this case, at least, the Canadians seem to have gotten it right. Thank goodness that, no matter how idiosyncratic our own National Anthem is, the first verse lyrics don't contain this kind of problem.
‘O Canada’ Gets a Gender-Neutral Version
The Canadian House of Commons tweaked the national anthem toward inclusion Wednesday.
Stupid Canada
+Joy Smith Why do you say that, Joy?
Srry I read that wrong nevermind srry again