It will be interesting to see how this plays out. There's certainly the appearance of a variety of business ties that, even if he is not (ostensibly) managing his business still end up lining his pockets. I'm not convinced that's his primary, or even secondary goal in being president, but it's a great perk.
The issue is, do those business ties and income rise to the level of violating laws regarding corruption and other such stuff (cf. the emoluments clause) and, if so, can the President actually be sued for them?
I expect this to be a looooooong case.
‘Major lawsuit’ against Trump promised by D.C., Maryland officials
Maryland and D.C. didn’t disclose the focus of their litigation, but The Washington Post reported that it involves foreign payments to Trump’s businesses.